[facebook 2] feat: add app to generate static site for facebook data#411
Merged
micahflee merged 9 commits intofacebook-export-importfrom Mar 4, 2025
Merged
[facebook 2] feat: add app to generate static site for facebook data#411micahflee merged 9 commits intofacebook-export-importfrom
micahflee merged 9 commits intofacebook-export-importfrom
Conversation
redshiftzero
force-pushed
the
facebook-webapp
branch
from
8c45c0b to
433ffae
Compare
redshiftzero
changed the title
redshiftzero
force-pushed
the
facebook-webapp
branch
from
1a43a87 to
945422c
Compare
redshiftzero
force-pushed
the
facebook-export-import
branch
from
0d473d0 to
3506cda
Compare
redshiftzero
force-pushed
the
facebook-webapp
branch
from
945422c to
bf83535
Compare
redshiftzero
force-pushed
the
facebook-export-import
branch
from
3506cda to
1798996
Compare
redshiftzero
changed the title
there is a lot of duplicated code here, just getting things working
redshiftzero
force-pushed
the
facebook-webapp
branch
from
bf83535 to
03daa4e
Compare
redshiftzero
changed the title
redshiftzero
changed the title
micahflee
reviewed
Mar 4, 2025
Member
micahflee
left a comment
micahflee
left a comment
There was a problem hiding this comment.
Hmm, for some reason I'm getting an error building the FB archive site. From archive-static-sites/facebook-archive:
$ npm run build
> facebook-archive@0.1.0 build
> vue-cli-service build
All browser targets in the browserslist configuration have supported ES module.
Therefore we don't build two separate bundles for differential loading.
⠇ Building for production...
ERROR Failed to compile with 1 error 6:06:54 PM
[eslint] No ESLint configuration found in /Users/user/code/cyd/archive-static-sites/facebook-archive/src.
You may use special comments to disable some warnings.
Use // eslint-disable-next-line to ignore the next line.
Use /* eslint-disable */ to ignore all warnings in a file.
ERROR Error: Build failed with errors.
Error: Build failed with errors.
at /Users/user/code/cyd/archive-static-sites/facebook-archive/node_modules/@vue/cli-service/lib/commands/build/index.js:207:23
at /Users/user/code/cyd/archive-static-sites/facebook-archive/node_modules/webpack/lib/webpack.js:168:8
at /Users/user/code/cyd/archive-static-sites/facebook-archive/node_modules/webpack/lib/HookWebpackError.js:67:2
at Hook.eval [as callAsync] (eval at create (/Users/user/code/cyd/archive-static-sites/facebook-archive/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Users/user/code/cyd/archive-static-sites/facebook-archive/node_modules/webpack/node_modules/tapable/lib/Hook.js:18:14)
at Cache.shutdown (/Users/user/code/cyd/archive-static-sites/facebook-archive/node_modules/webpack/lib/Cache.js:154:23)
at /Users/user/code/cyd/archive-static-sites/facebook-archive/node_modules/webpack/lib/Compiler.js:1379:15
at Hook.eval [as callAsync] (eval at create (/Users/user/code/cyd/archive-static-sites/facebook-archive/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Users/user/code/cyd/archive-static-sites/facebook-archive/node_modules/webpack/node_modules/tapable/lib/Hook.js:18:14)
at Compiler.close (/Users/user/code/cyd/archive-static-sites/facebook-archive/node_modules/webpack/lib/Compiler.js:1372:23)
Did you get this problem?
Contributor
Author
|
added a commit that should resolve |
micahflee
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR on #405 (i.e. when that is merged, this can be re-targeted to
main)Closes #399
Still marked WIP because there's a test failure to debugseemed to be a flake, reran the test suite and all passed 🤔